fix(compiler): make projectReferences work with LanguageService#1541
Merged
ahnpnl merged 4 commits intokulshekhar:masterfrom Apr 19, 2020
ahnpnl:project-references-part-2
Merged
fix(compiler): make projectReferences work with LanguageService#1541ahnpnl merged 4 commits intokulshekhar:masterfrom ahnpnl:project-references-part-2
projectReferences work with LanguageService#1541ahnpnl merged 4 commits intokulshekhar:masterfrom
ahnpnl:project-references-part-2
Conversation
Pull Request Test Coverage Report for Build 4454
💛 - Coveralls |
kulshekhar
approved these changes
Apr 19, 2020
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finish the remaining the work of #1527 , this PR makes
projectReferenceswork withLanguageService, close #766Caveat:
It is required to build the project first with
tsc -bto have the compiled files ready. Includingtsc -bwill be done in #1159Test plan
isolatedModules: trueand one composite project to test withisolatedModules: false.Does this PR introduce a breaking change?
Other information
N.A.